set role/group last review date check differenly for new and updated objects #2533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…objects Signed-off-by: Henry Avetisyan <hga@yahooinc.com>
abvaidya
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
set up different limits for new and updated roles/groups when setting up the last reviewed date check. for updated objects, we won't allow by default 7 days (increased from 3 days) and for new objects we just use max of 1 year - in this case it doesn't really matter much since the object is new but we don't want the admin to set some really old value for last reviewed date.
Contribution Checklist:
Attach Screenshots (Optional)